Skip to content

Conversation

@echohlne
Copy link
Contributor

@echohlne echohlne commented Oct 14, 2020

What changes were proposed in this pull request?

In Execution web page, when Succeeded Job(or Failed Jobs) has many child url elements,they will extend over the edge of the page.

Why are the changes needed?

To make the page more friendly.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Munual test result shows as below:

fixed

@echohlne
Copy link
Contributor Author

cc: @sarutak @gengliangwang

@gengliangwang
Copy link
Member

ok to test

@gengliangwang
Copy link
Member

@akiyamaneko Thanks for the improvement!
Could you add the screenshot after fix in the PR description?

@SparkQA
Copy link

SparkQA commented Oct 16, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34497/

@echohlne
Copy link
Contributor Author

echohlne commented Oct 16, 2020

@gengliangwang I have attached the screenshot, or you can visit this: fix-screenshot

@SparkQA
Copy link

SparkQA commented Oct 16, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34497/

Copy link
Member

@gengliangwang gengliangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengliangwang
Copy link
Member

Thanks, merging to master

@SparkQA
Copy link

SparkQA commented Oct 16, 2020

Test build #129892 has finished for PR 30035 at commit db61218.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@echohlne echohlne deleted the sql_execution_job_overflow branch October 17, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants