[SPARK-32405][SQL][FOLLOWUP] Throw Exception if provider is specified in JDBCTableCatalog create table #30544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maropu
changed the title
Member
|
cc @MaxGekk FYI |
|
Test build #131970 has finished for PR 30544 at commit
|
Contributor
Author
|
also cc @cloud-fan |
cloud-fan
reviewed
Dec 1, 2020
| properties.asScala.map { | ||
| case (k, v) => k match { | ||
| case "comment" => tableComment = v | ||
| // ToDo: have a follow up to fail provider once unify create table syntax PR is merged |
cloud-fan
approved these changes
Dec 1, 2020
Contributor
|
thanks, merging to master! |
Contributor
Author
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Throw Exception if JDBC Table Catalog has provider in create table.
Why are the changes needed?
JDBC Table Catalog doesn't support provider and we should throw Exception. Previously CREATE TABLE syntax forces people to specify a provider so we have to add a
USING_. Now the problem was fix and we will throw Exception for provider.Does this PR introduce any user-facing change?
Yes. We throw Exception if a provider is specified in CREATE TABLE for JDBC Table catalog.
How was this patch tested?
Existing tests (remove
USING _)