[SPARK-33364][SQL][FOLLOWUP] Refine the catalog v2 API to purge a table#30890
[SPARK-33364][SQL][FOLLOWUP] Refine the catalog v2 API to purge a table#30890cloud-fan wants to merge 2 commits intoapache:masterfrom
Conversation
| * @return true if a table was deleted, false if no table exists for the identifier | ||
| * @throws UnsupportedOperationException If table purging is not supported | ||
| * | ||
| * @since 3.1.0 |
There was a problem hiding this comment.
Are you going to backport this to branch-3.1?
There was a problem hiding this comment.
Yea, otherwise it's a breaking change and is not accepted.
|
There are tests for the Should we add similar primitive tests for purgeTable() there?
|
|
Kubernetes integration test starting |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #133223 has finished for PR 30890 at commit
|
|
Test build #133228 has finished for PR 30890 at commit
|
|
Merged to master and branch-3.1. |
This is a followup of #30267 Inspired by #30886, it's better to have 2 methods `def dropTable` and `def purgeTable`, than `def dropTable(ident)` and `def dropTable(ident, purge)`. 1. make the APIs orthogonal. Previously, `def dropTable(ident, purge)` calls `def dropTable(ident)` and is a superset. 2. simplifies the catalog implementation a little bit. Now the `if (purge) ... else ...` check is done at the Spark side. No. existing tests Closes #30890 from cloud-fan/purgeTable. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit ec1560a) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
What changes were proposed in this pull request?
This is a followup of #30267
Inspired by #30886, it's better to have 2 methods
def dropTableanddef purgeTable, thandef dropTable(ident)anddef dropTable(ident, purge).Why are the changes needed?
def dropTable(ident, purge)callsdef dropTable(ident)and is a superset.if (purge) ... else ...check is done at the Spark side.Does this PR introduce any user-facing change?
No.
How was this patch tested?
existing tests