[SPARK-33824][PYTHON][DOCS][FOLLOW-UP] Clarify about PYSPARK_DRIVER_PYTHON and spark.yarn.appMasterEnv.PYSPARK_PYTHON#30938
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Member
Author
|
Test build #133408 has finished for PR 30938 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
srowen
approved these changes
Dec 27, 2020
viirya
approved these changes
Dec 27, 2020
Member
Author
|
Thanks guys, merged to master and branch-3.1. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Dec 28, 2020
…YTHON and spark.yarn.appMasterEnv.PYSPARK_PYTHON ### What changes were proposed in this pull request? This PR proposes to clarify: - `PYSPARK_DRIVER_PYTHON` should not be set for cluster modes in YARN and Kubernates. - `spark.yarn.appMasterEnv.PYSPARK_PYTHON` is not required in YARN. This is just another way to set `PYSPARK_PYTHON` that is specific for a Spark application. ### Why are the changes needed? To clarify what's required and not. ### Does this PR introduce _any_ user-facing change? Yes, this is a user-facing doc change. ### How was this patch tested? Manually tested. Note that this credits to gaborgsomogyi who actually tested and raised a doubt about this offline to me. I also manually tested all again to double check. Closes #30938 from HyukjinKwon/SPARK-33824-followup. Authored-by: Gabor Somogyi <gabor.g.somogyi@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 678294d) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to clarify:
PYSPARK_DRIVER_PYTHONshould not be set for cluster modes in YARN and Kubernates.spark.yarn.appMasterEnv.PYSPARK_PYTHONis not required in YARN. This is just another way to setPYSPARK_PYTHONthat is specific for a Spark application.Why are the changes needed?
To clarify what's required and not.
Does this PR introduce any user-facing change?
Yes, this is a user-facing doc change.
How was this patch tested?
Manually tested.
Note that this credits to @gaborgsomogyi who actually tested and raised a doubt about this offline to me.
I also manually tested all again to double check.