[SPARK-28123][SQL] String Functions: support btrim#31080
Closed
beliefer wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-28123][SQL] String Functions: support btrim#31080beliefer wants to merge 1 commit intoapache:masterfrom
beliefer wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #133780 has finished for PR 31080 at commit
|
Contributor
Author
|
retest this please |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #133790 has finished for PR 31080 at commit
|
Contributor
Author
|
retest this please |
|
Test build #133801 has started for PR 31080 at commit |
Contributor
Author
|
cc @cloud-fan |
Member
|
Per the other PR/JIRA discussion, I'm still skeptical about the use case for this function. IF it's just that legacy DBs support it, it may not be worth it just for that reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The current implement of
Trim/Ltrim/Rtrimonly support string, but support byte array is very useful.The function btrim supports byte array.
The mainstream database support this feature show below:
Postgresql
https://www.postgresql.org/docs/11/functions-binarystring.html
Vertica
https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/SQLReferenceManual/Functions/String/BTRIM.htm?tocpath=SQL%20Reference%20Manual%7CSQL%20Functions%7CString%20Functions%7C_____5
Redshift
https://docs.aws.amazon.com/redshift/latest/dg/r_BTRIM.html
Druid
https://druid.apache.org/docs/latest/querying/sql.html#string-functions
Greenplum
http://docs.greenplum.org/6-8/ref_guide/function-summary.html
Why are the changes needed?
btrim is very useful.
Does this PR introduce any user-facing change?
Yes. btrim is a new function
How was this patch tested?
Jenkins test.