[SPARK-33542][SQL][FOLLOWUP] Group exception messages in catalyst/catalog#31312
Closed
beliefer wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-33542][SQL][FOLLOWUP] Group exception messages in catalyst/catalog#31312beliefer wants to merge 2 commits intoapache:masterfrom
beliefer wants to merge 2 commits intoapache:masterfrom
Conversation
|
Test build #134420 has finished for PR 31312 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #134422 has finished for PR 31312 at commit
|
Contributor
Author
allisonwang-db
approved these changes
Jan 27, 2021
Contributor
Author
|
cc @cloud-fan |
cloud-fan
approved these changes
Jan 28, 2021
Contributor
|
thanks, merging to master! |
Contributor
Author
|
@allisonwang-db @cloud-fan Thanks a lot! |
skestle
pushed a commit
to skestle/spark
that referenced
this pull request
Feb 3, 2021
…alog ### What changes were proposed in this pull request? This PR follows up apache#30870. Maybe some contributors don't know the job and added some exception by the old way. ### Why are the changes needed? It will largely help with standardization of error messages and its maintenance. ### Does this PR introduce _any_ user-facing change? No. Error messages remain unchanged. ### How was this patch tested? No new tests - pass all original tests to make sure it doesn't break any existing behavior. Closes apache#31312 from beliefer/SPARK-33542-followup. Authored-by: beliefer <beliefer@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR follows up #30870.
Maybe some contributors don't know the job and added some exception by the old way.
Why are the changes needed?
It will largely help with standardization of error messages and its maintenance.
Does this PR introduce any user-facing change?
No. Error messages remain unchanged.
How was this patch tested?
No new tests - pass all original tests to make sure it doesn't break any existing behavior.