Skip to content

Conversation

@ulysses-you
Copy link
Contributor

What changes were proposed in this pull request?

Add function exists check before load resource.

Why are the changes needed?

We should not add jar into classpath if the create temporary function is already exists.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Add test.

@github-actions github-actions bot added the SQL label Jan 27, 2021
@SparkQA
Copy link

SparkQA commented Jan 27, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39129/

@SparkQA
Copy link

SparkQA commented Jan 27, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39129/

@SparkQA
Copy link

SparkQA commented Jan 27, 2021

Test build #134543 has finished for PR 31358 at commit da3e7b3.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 27, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39141/

@SparkQA
Copy link

SparkQA commented Jan 27, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39141/

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine to me if this doesn't change behavior, just fails earlier.

@SparkQA
Copy link

SparkQA commented Jan 27, 2021

Test build #134555 has finished for PR 31358 at commit 590b0b3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ulysses-you
Copy link
Contributor Author

thanks @srowen , also cc @maropu @cloud-fan

@maropu
Copy link
Member

maropu commented Jan 29, 2021

Thanks! Merged to master.

@maropu maropu closed this Jan 29, 2021
maropu pushed a commit that referenced this pull request Jan 29, 2021
### What changes were proposed in this pull request?

Add function exists check before load resource.

### Why are the changes needed?

We should not add jar into classpath if the create temporary function is already exists.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Add test.

Closes #31358 from ulysses-you/SPARK-34261.

Authored-by: ulysses-you <ulyssesyou18@gmail.com>
Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
@ulysses-you
Copy link
Contributor Author

thanks for merging !

@ulysses-you ulysses-you deleted the SPARK-34261 branch January 29, 2021 01:54
skestle pushed a commit to skestle/spark that referenced this pull request Feb 3, 2021
### What changes were proposed in this pull request?

Add function exists check before load resource.

### Why are the changes needed?

We should not add jar into classpath if the create temporary function is already exists.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Add test.

Closes apache#31358 from ulysses-you/SPARK-34261.

Authored-by: ulysses-you <ulyssesyou18@gmail.com>
Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants