-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-34261][SQL] Avoid side effect if create exists temporary function #31358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #134543 has finished for PR 31358 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems fine to me if this doesn't change behavior, just fails earlier.
|
Test build #134555 has finished for PR 31358 at commit
|
|
thanks @srowen , also cc @maropu @cloud-fan |
|
Thanks! Merged to master. |
### What changes were proposed in this pull request? Add function exists check before load resource. ### Why are the changes needed? We should not add jar into classpath if the create temporary function is already exists. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add test. Closes #31358 from ulysses-you/SPARK-34261. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
|
thanks for merging ! |
### What changes were proposed in this pull request? Add function exists check before load resource. ### Why are the changes needed? We should not add jar into classpath if the create temporary function is already exists. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add test. Closes apache#31358 from ulysses-you/SPARK-34261. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
What changes were proposed in this pull request?
Add function exists check before load resource.
Why are the changes needed?
We should not add jar into classpath if the create temporary function is already exists.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add test.