[SPARK-34299][SQL] Clean up ResolveSessionCatalog's isTempView and isTempFunction #31400
+4
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
HyukjinKwon
approved these changes
Jan 31, 2021
Member
|
Merged to master. |
|
Test build #134682 has finished for PR 31400 at commit
|
skestle
pushed a commit
to skestle/spark
that referenced
this pull request
Feb 3, 2021
…TempFunction ### What changes were proposed in this pull request? `ResolveSessionCatalog`'s `isTempView` and `isTempFunction` are not being used anymore since the resolution of temp view/function has moved to `Analyzer`. This PR proposes to remove `isTempView` and `isTempFunction` from `ResolveSessionCatalog`. ### Why are the changes needed? To clean up unused variables. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests should cover as this PR just removes the unused variables. Closes apache#31400 from imback82/cleanup_resolve_session_catalog. Authored-by: Terry Kim <yuminkim@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ResolveSessionCatalog'sisTempViewandisTempFunctionare not being used anymore since the resolution of temp view/function has moved toAnalyzer.This PR proposes to remove
isTempViewandisTempFunctionfromResolveSessionCatalog.Why are the changes needed?
To clean up unused variables.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests should cover as this PR just removes the unused variables.