[SPARK-34325][CORE] Remove unused shuffleBlockResolver variable inSortShuffleWriter #31433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@srowen @HeartSaVioR Please take a review, thanks. |
| import org.apache.spark.util.collection.ExternalSorter | ||
|
|
||
| private[spark] class SortShuffleWriter[K, V, C]( | ||
| shuffleBlockResolver: IndexShuffleBlockResolver, |
Author
There was a problem hiding this comment.
Yes, it's not used here, i think someone forget to remove this when separate this part logic to LocalDiskShuffleDataIO.
Member
|
ok to test |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #134767 has finished for PR 31433 at commit
|
srowen
approved these changes
Feb 2, 2021
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Seems OK if it's really unused.
HyukjinKwon
approved these changes
Feb 3, 2021
HyukjinKwon
changed the title
Member
|
Merged to master. |
skestle
pushed a commit
to skestle/spark
that referenced
this pull request
Feb 3, 2021
…tShuffleWriter ### What changes were proposed in this pull request? Remove unused shuffleBlockResolver variable in SortShuffleWriter. ### Why are the changes needed? For better code understanding. ### Does this PR introduce _any_ user-facing change? NO. ### How was this patch tested? End to End. Closes apache#31433 from offthewall123/remove_shuffleBlockResolver_in_SortShuffleWriter. Authored-by: offthewall123 <dingyu.xu@intel.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
domybest11
pushed a commit
to domybest11/spark
that referenced
this pull request
Jun 15, 2022
…tShuffleWriter ### What changes were proposed in this pull request? Remove unused shuffleBlockResolver variable in SortShuffleWriter. ### Why are the changes needed? For better code understanding. ### Does this PR introduce _any_ user-facing change? NO. ### How was this patch tested? End to End. Closes apache#31433 from offthewall123/remove_shuffleBlockResolver_in_SortShuffleWriter. Authored-by: offthewall123 <dingyu.xu@intel.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unused shuffleBlockResolver variable in SortShuffleWriter.
Why are the changes needed?
For better code understanding.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
End to End.