[SPARK-34330][SQL] Literal's constructor support UTF8String #31438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @maropu @cloud-fan |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
cloud-fan
reviewed
Feb 2, 2021
| case b: Byte => Literal(b, ByteType) | ||
| case s: Short => Literal(s, ShortType) | ||
| case s: String => Literal(UTF8String.fromString(s), StringType) | ||
| case s: UTF8String => Literal(s, StringType) |
Contributor
There was a problem hiding this comment.
IIUC, Literal.apply is for external values. If you have internal values like UTF8String, you should use Literal(value, dt).
Member
There was a problem hiding this comment.
Yeah, let's don't do this here.
Contributor
Author
There was a problem hiding this comment.
OK, tried that all case can be handled. Close this one
|
Test build #134781 has finished for PR 31438 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since when
UnsafeRow.getStringreturn UTF8String, butLiteral.apply()don't support UF8String.In this patch support it.
Why are the changes needed?
Make Literal's constructor support UTF8String
Does this PR introduce any user-facing change?
When s is instance of
UTF8Stringuser can use
Literal(s)How was this patch tested?
Not need