Skip to content

[PYTHON][MINOR] Fix docstring of DataFrame.join#31463

Closed
xinrong-meng wants to merge 1 commit intoapache:masterfrom
xinrong-meng:fixDoc
Closed

[PYTHON][MINOR] Fix docstring of DataFrame.join#31463
xinrong-meng wants to merge 1 commit intoapache:masterfrom
xinrong-meng:fixDoc

Conversation

@xinrong-meng
Copy link
Member

@xinrong-meng xinrong-meng commented Feb 3, 2021

What changes were proposed in this pull request?

Fix docstring of PySpark DataFrame.join.

Why are the changes needed?

For a better view of PySpark documentation.

Does this PR introduce any user-facing change?

No (only documentation changes).

How was this patch tested?

Manual test.

From
image

To
image

@srowen
Copy link
Member

srowen commented Feb 4, 2021

Seems fine - are there other instances?
You can mark it as non-WIP / not draft.

@maropu maropu changed the title [WIP] Fix docstring of join [PYTHON][MINOR] Fix docstring of join Feb 5, 2021
@maropu
Copy link
Member

maropu commented Feb 5, 2021

ok to test

@maropu
Copy link
Member

maropu commented Feb 5, 2021

Looks fine.

@xinrong-meng xinrong-meng marked this pull request as ready for review February 5, 2021 01:13
@xinrong-meng
Copy link
Member Author

Thank you for your reviews!

@srowen I don't see other instances so far. I've marked the PR as non-draft.

@xinrong-meng xinrong-meng changed the title [PYTHON][MINOR] Fix docstring of join [PYTHON][MINOR] Fix docstring of DataFrame.join Feb 5, 2021
@SparkQA
Copy link

SparkQA commented Feb 5, 2021

Test build #134900 has finished for PR 31463 at commit 08dcbd1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen closed this in 747ad18 Feb 6, 2021
srowen pushed a commit that referenced this pull request Feb 6, 2021
### What changes were proposed in this pull request?
Fix docstring of PySpark `DataFrame.join`.

### Why are the changes needed?
For a better view of PySpark documentation.

### Does this PR introduce _any_ user-facing change?
No (only documentation changes).

### How was this patch tested?
Manual test.

From
![image](https://user-images.githubusercontent.com/47337188/106977730-c14ab080-670f-11eb-8df8-5aea90902104.png)

To
![image](https://user-images.githubusercontent.com/47337188/106977834-ed663180-670f-11eb-9c5e-d09be26e0ca8.png)

Closes #31463 from xinrong-databricks/fixDoc.

Authored-by: Xinrong Meng <xinrong.meng@databricks.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
(cherry picked from commit 747ad18)
Signed-off-by: Sean Owen <srowen@gmail.com>
@srowen
Copy link
Member

srowen commented Feb 6, 2021

Merged to master/3.1

@xinrong-meng
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants