Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR proposes to use _create_udf where we need to create UserDefinedFunction to maintain codes easier.

Why are the changes needed?

For the better readability of codes and maintenance.

Does this PR introduce any user-facing change?

No, refactoring.

How was this patch tested?

Ran the existing unittests. CI in this PR should test it out too.

@HyukjinKwon
Copy link
Member Author

cc @ueshin @viirya can you take a quick look please?

@SparkQA
Copy link

SparkQA commented Feb 9, 2021

Test build #135072 has finished for PR 31537 at commit 9ea7ebe.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HyukjinKwon
Copy link
Member Author

Thanks @ueshin. Merged to master.

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late lgtm

@HyukjinKwon HyukjinKwon deleted the SPARK-34408 branch January 4, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants