Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Feb 19, 2021

What changes were proposed in this pull request?

This PR aims to make KubernetesClusterSchedulerBackend ignore RegisterExecutor message when SparkContext is stopped already.

Why are the changes needed?

If SparkDriver is terminated, the executors will be removed by K8s automatically.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the newly added test case.

@SparkQA
Copy link

SparkQA commented Feb 19, 2021

Test build #135255 has finished for PR 31587 at commit b2a34f8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 19, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39835/

@SparkQA
Copy link

SparkQA commented Feb 19, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39835/

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-34469 branch February 19, 2021 17:50
dongjoon-hyun added a commit that referenced this pull request Feb 21, 2021
### What changes were proposed in this pull request?

This PR aims to make `KubernetesClusterSchedulerBackend` ignore `RegisterExecutor` message when `SparkContext` is stopped already.

### Why are the changes needed?

If `SparkDriver` is terminated, the executors will be removed by K8s automatically.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the newly added test case.

Closes #31587 from dongjoon-hyun/SPARK-34469.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun
Copy link
Member Author

This is backported to branch-3.1 to fix a bug situation when the late arrival executor pods causes a delay of SparkContext.stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants