Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Feb 27, 2021

What changes were proposed in this pull request?

Avro add zstandard codec since AVRO-2195. This pr add zstandard codec to Avro compression codec list.

Why are the changes needed?

To make Avro support zstandard codec.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unit test.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sharing PR, @wangyum . I believe we can collaborate to fix the issue and merge this PR soon via luben/zstd-jni#161 .

@SparkQA
Copy link

SparkQA commented Feb 27, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40116/

@SparkQA
Copy link

SparkQA commented Feb 27, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40116/

@dongjoon-hyun
Copy link
Member

I made a PR. It will unblock this issue.

I verified the new ZSTD JNI library on top of this PR. AvroV1Suite and AvroV2Suite passed.

@dongjoon-hyun
Copy link
Member

Could you rebase this PR to the master?

@SparkQA
Copy link

SparkQA commented Feb 27, 2021

Test build #135535 has finished for PR 31673 at commit 136c5b0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 27, 2021

Test build #135541 has finished for PR 31673 at commit 309de76.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you!
Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants