Skip to content

Conversation

@AngersZhuuuu
Copy link
Contributor

What changes were proposed in this pull request?

Some UT in SQLQuerySuite is not incorrect, it have wrong table name in withTable, this pr to make it correct.

Why are the changes needed?

Fix UT

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existed UT

@github-actions github-actions bot added the SQL label Feb 28, 2021
@maropu maropu changed the title [SPARK-34579][SQL] Fix wrong UT in SQLQuerySuite [SPARK-34579][SQL][TEST] Fix wrong UT in SQLQuerySuite Feb 28, 2021
@SparkQA
Copy link

SparkQA commented Feb 28, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40136/

@SparkQA
Copy link

SparkQA commented Feb 28, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40136/

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Was the test OK, just not cleaning up after itself?

@SparkQA
Copy link

SparkQA commented Feb 28, 2021

Test build #135555 has finished for PR 31681 at commit 158b0d5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

The doc generation job seems to be broken since #31535 .

@dongjoon-hyun
Copy link
Member

Ur, @AngersZhuuuu . the PR title seems to have a wrong JIRA issue

@AngersZhuuuu AngersZhuuuu changed the title [SPARK-34579][SQL][TEST] Fix wrong UT in SQLQuerySuite [SPARK-34569][SQL][TEST] Fix wrong UT in SQLQuerySuite Mar 1, 2021
@AngersZhuuuu
Copy link
Contributor Author

Ur, @AngersZhuuuu . the PR title seems to have a wrong JIRA issue

updated. Hmmm.

@dongjoon-hyun
Copy link
Member

Unfortunately, we cannot change the commit log, @AngersZhuuuu . Let's see if we can switch the new SPARK-34579 with this because it's not created yet.

@AngersZhuuuu
Copy link
Contributor Author

Yea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants