[SPARK-34589][CORE] Make BypassMergeSortShuffleWriter close partitionWriters in case of success#31704
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-34589
Closed
[SPARK-34589][CORE] Make BypassMergeSortShuffleWriter close partitionWriters in case of success#31704dongjoon-hyun wants to merge 1 commit intoapache:masterfrom dongjoon-hyun:SPARK-34589
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-34589
Conversation
…Writers in case of success
Member
Author
|
Test build #135634 has started for PR 31704 at commit |
Member
Author
|
Oops. Sorry guys. I realized that |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to close
partitionWriterswhenBypassMergeSortShuffleWriter.stopwith success.Why are the changes needed?
In case of failure, we call
writer.revertPartialWritesAndCloseand delete the files.Likewise, we had better close the resources at this level.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the existing UTs.