[SPARK-22748][SQL] Analyze __grouping__id as a literal function#31751
Closed
maropu wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-22748][SQL] Analyze __grouping__id as a literal function#31751maropu wants to merge 1 commit intoapache:masterfrom
maropu wants to merge 1 commit intoapache:masterfrom
Conversation
maropu
commented
Mar 5, 2021
| } | ||
| } | ||
|
|
||
| test("SPARK-22748: Analyze __grouping__id as a literal function") { |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
cloud-fan
approved these changes
Mar 5, 2021
Contributor
|
thanks, merging to master! |
viirya
reviewed
Mar 5, 2021
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
this looks making more sense than original one. lgtm.
|
Test build #135792 has finished for PR 31751 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR intends to refactor the logic to resolve
__grouping_idin theAnalyzer; it moves the logic fromResolveFunctionstoResolveReferences(resolveLiteralFunction).The original author of this PR is @sqlwindspeaker (#30781).
Closes #30781.
Why are the changes needed?
Code refactoring.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added tests in
AnalysisSuite.