[SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute#31845
Closed
c21 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-34729][SQL][FOLLOWUP] Broadcast nested loop join to use executeTake instead of execute#31845c21 wants to merge 1 commit intoapache:masterfrom
c21 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
cc @cloud-fan and @maropu could you help take a look when you have time, thanks. |
dongjoon-hyun
changed the title
Member
|
Hi, @c21 . |
Contributor
Author
|
@dongjoon-hyun - thanks for correction. I was wrongly assuming followup PRs should not use original JIRA id. Will follow the convention next time, thanks. |
Member
|
BTW, GitHub Action is currently broken. |
Contributor
Author
|
retest this please |
Contributor
Author
|
Closed & reopened PR to trigger unit test in github action. |
maropu
approved these changes
Mar 16, 2021
dongjoon-hyun
approved these changes
Mar 16, 2021
Member
|
Merged to master. |
Contributor
Author
|
Thank you @dongjoon-hyun and @maropu for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup minor change from #31821 (comment) , where we change from using
execute()toexecuteTake(). Performance-wise there's no difference. We are just using a different API to be aligned with code path ofDataset.Why are the changes needed?
To align with other code paths in SQL/Dataset.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests same as #31821 .