[WIP][SPARK-34847][SQL] Simplify ResolveAggregateFunctions#31947
[WIP][SPARK-34847][SQL] Simplify ResolveAggregateFunctions#31947cloud-fan wants to merge 1 commit intoapache:masterfrom
Conversation
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Kubernetes integration test starting |
|
Test build #136435 has finished for PR 31947 at commit
|
|
Kubernetes integration test status failure |
|
Test build #136437 has finished for PR 31947 at commit
|
|
The current solution doesn't work with subqueries and needs more time to investigate. |
|
Test build #136469 has finished for PR 31947 at commit
|
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
What changes were proposed in this pull request?
The current
ResolveAggregateFunctionsis very complicated. It recursively calls the entire analyzer, and has duplicated code forFilterandSort.This PR simplifies
ResolveAggregateFunctionsand just resolves the Filter condition/Sort ordering with Aggregate, instead of running the entire analyzer again. It also unifies the code for Filter and Sort.Why are the changes needed?
Code cleanup and speed up query compilation.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests and run
TPCDSQuerySuitelocally.Before this PR
After this PR