You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dbaliafroozeh
changed the title
[SPARK-34969]
[SPARK-34969] Followup for SPARK-34906
Apr 6, 2021
dbaliafroozeh
changed the title
[SPARK-34969] Followup for SPARK-34906
[SPARK-34969] Followup for Refactor TreeNode's children handling methods into specialized traits (SPARK-34906)
Apr 6, 2021
The reason will be displayed to describe this comment to others. Learn more.
LGTM
maropu
changed the title
[SPARK-34969] Followup for Refactor TreeNode's children handling methods into specialized traits (SPARK-34906)
[SPARK-34969][SPARK-34906][SQL] Followup for Refactor TreeNode's children handling methods into specialized traits
Apr 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup for #31932.
In this PR we:
QuaternaryLiketrait for node types with 4 children.Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
This is a refactoring, passes existing tests.