[SPARK-35170][SQL] Extend BinaryOperator by SubtractDates and SubtractTimestamps

[MaxGekk]

What changes were proposed in this pull request?

In the PR, I propose to modify the SubtractDates and SubtractTimestamps expressions to extend BinaryOperator instead of BinaryExpression.

Why are the changes needed?

To improve code maintenance.

Does this PR introduce any user-facing change?

No

How was this patch tested?

By existing test suites.

[MaxGekk]

@gengliangwang @cloud-fan FYI, this PR changes behavior in errors slightly (I guess it is not critical) :

[info] - typeCoercion/native/promoteStrings.sql *** FAILED *** (5 seconds, 764 milliseconds)
[info]   typeCoercion/native/promoteStrings.sql
[info]   Expected "...data type mismatch: [argument 1 requires timestamp type, however, ''1'' is of string type].; line 1 pos 7", but got "...data type mismatch: [differing types in '('1' - CAST('2017-12-11 09:30:00.0' AS TIMESTAMP))' (string and timestamp)].; line 1 pos 7" Result did not match for query #23

[info]   typeCoercion/native/decimalPrecision.sql
[info]   Expected "...data type mismatch: [argument 2 requires timestamp type, however, 'CAST(1 AS DECIMAL(3,0))' is of decimal(3,0) type].; line 1 pos 7", but got "...data type mismatch: [differing types in '(CAST('2017-12-11 09:30:00.0' AS TIMESTAMP) - CAST(1 AS DECIMAL(3,0)))' (timestamp and decimal(3,0))].; line 1 pos 7" Result did not match for query #121
[info]   SELECT cast('2017-12-11 09:30:00.0' as timestamp) - cast(1 as decimal(3, 0)) FROM t (SQLQueryTestSuite.scala:459)

[MaxGekk]

Though, no. It changes the behavior actually - an exception instead of NULL:

[info] - typeCoercion/native/promoteStrings.sql *** FAILED *** (13 seconds, 407 milliseconds)
[info]   "NULL" did not contain "Exception" Exception did not match for query #24
[info]   SELECT '1' - cast('2017-12-11 09:30:00' as date)        FROM t, expected: NULL, but got: java.sql.SQLException
[info]   org.apache.hive.service.cli.HiveSQLException: Error running query: org.apache.spark.sql.AnalysisException: cannot resolve '('1' - CAST('2017-12-11 09:30:00' AS DATE))' due to data type mismatch: differing types in '('1' - CAST('2017-12-11 09:30:00' AS DATE))' (string and date).; line 1 pos 7;

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42251/

[SparkQA]

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42251/

[MaxGekk]

@cloud-fan @gengliangwang Are we ok to change the behavior?

[gengliangwang]

This doesn't look good...Why does that happen?

[cloud-fan]

Probably because we have special type coercion logic for BinaryOperators?

[MaxGekk]

From my point of view, old error looks better.

[gengliangwang]

+1

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42260/

[SparkQA]

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42260/

[SparkQA]

Test build #137724 has finished for PR 32267 at commit 02e2fbb.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #137733 has finished for PR 32267 at commit f0abdbf.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[MaxGekk]

I am closing this because:

1. Behavior change
2. New error message becomes worse