[SPARK-35233][2.4][BUILD] Switch from bintray to scala.jfrog.io for SBT download in branch 2.4 and 3.0#32352
Closed
sunchao wants to merge 1 commit intoapache:branch-2.4from
Closed
[SPARK-35233][2.4][BUILD] Switch from bintray to scala.jfrog.io for SBT download in branch 2.4 and 3.0#32352sunchao wants to merge 1 commit intoapache:branch-2.4from
sunchao wants to merge 1 commit intoapache:branch-2.4from
Conversation
Member
Author
|
cc @viirya |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
viirya
approved these changes
Apr 26, 2021
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
LGTM. Verified locally with the change.
|
Test build #137968 has finished for PR 32352 at commit
|
|
Refer to this link for build results (access rights to CI server needed): |
Member
|
Thanks @sunchao! Merging to 2.4. |
viirya
pushed a commit
that referenced
this pull request
Apr 26, 2021
…BT download in branch 2.4 and 3.0 ### What changes were proposed in this pull request? Move SBT download URL from `https://dl.bintray.com/typesafe` to `https://scala.jfrog.io/artifactory`. ### Why are the changes needed? As [bintray is sunsetting](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/), we should migrate SBT download location away from it. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Tested manually and it is working, while previously it was failing because SBT 0.13.17 can't be found: ``` Attempting to fetch sbt Our attempt to download sbt locally to build/sbt-launch-0.13.17.jar failed. Please install sbt manually from http://www.scala-sbt.org/ ``` Closes #32352 from sunchao/SPARK-35233. Authored-by: Chao Sun <sunchao@apple.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
Member
|
+1, LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move SBT download URL from
https://dl.bintray.com/typesafetohttps://scala.jfrog.io/artifactory.Why are the changes needed?
As bintray is sunsetting, we should migrate SBT download location away from it.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested manually and it is working, while previously it was failing because SBT 0.13.17 can't be found: