[SPARK-34878][SQL][TESTS] Check actual sizes of year-month and day-time intervals#32366
Closed
Peng-Lei wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-34878][SQL][TESTS] Check actual sizes of year-month and day-time intervals#32366Peng-Lei wants to merge 1 commit intoapache:masterfrom
Peng-Lei wants to merge 1 commit intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
MaxGekk
changed the title
MaxGekk
reviewed
Apr 27, 2021
sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnTypeSuite.scala
Outdated
Show resolved
Hide resolved
MaxGekk
reviewed
Apr 27, 2021
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
@Peng-Lei The added objects can be used in SPARK-35243
Comment on lines
284
to
285
Member
There was a problem hiding this comment.
Suggested change
| override def copyField(from: InternalRow, fromOrdinal: Int, | |
| to: InternalRow, toOrdinal: Int): Unit = { | |
| override def copyField( | |
| from: InternalRow, | |
| fromOrdinal: Int, | |
| to: InternalRow, | |
| toOrdinal: Int): Unit = { |
See rules for indentations at https://github.com/databricks/scala-style-guide#spacing-and-indentation
Comment on lines
313
to
314
Contributor
Author
Thank you very much，It seems that you have found a task for me. Thanks again |
MaxGekk
approved these changes
Apr 28, 2021
Member
|
+1, LGTM. Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As we have suport the year-month and day-time intervals. Add the test actual size of year-month and day-time intervals type
Why are the changes needed?
Just add test
Does this PR introduce any user-facing change?
No
How was this patch tested?
./dev/scalastyle
run test for "ColumnTypeSuite"