[WIP][GRAPHX] Allow to turn off the normalization applied in the end of static PageRank utilities#32484
Closed
ebonnal wants to merge 1 commit into
Closed
[WIP][GRAPHX] Allow to turn off the normalization applied in the end of static PageRank utilities#32484ebonnal wants to merge 1 commit into
ebonnal wants to merge 1 commit into
Conversation
|
Can one of the admins verify this patch? |
e9430da to
0150eda
Compare
…nk with a 'normalized' parameter to trigger or not the normalization
0150eda to
e407e88
Compare
Contributor
Author
|
replaced by #32485 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Overload methods
PageRank.runWithOptionsandPageRank.runWithOptionsWithPreviousPageRank(not to break any user-facing signature) with anormalizedparameter that describes "whether or not to normalize the rank sum".Why are the changes needed?
https://issues.apache.org/jira/browse/SPARK-
When dealing with a non negligible proportion of sinks in a graph, algorithm based on incremental update of ranks can get a precision gain for free if they are allowed to manipulate non normalized ranks.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By adding a unit test that verifies that (even when dealing with a graph containing a sink) we end up with the same result for both these scenarios:
a)
PageRank.runWithOptionswith normalization enabledb)
PageRank.runWithOptionswith normalization disabledpreRankGraph1and run 2 more iterations usingPageRank.runWithOptionsWithPreviousPageRankwith normalization disabledpreRankGraph2and run 2 more iterations usingPageRank.runWithOptionsWithPreviousPageRankwith normalization enabled