-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-35427][SQL][TESTS] Check the EXCEPTION rebase mode for Avro/Parquet
#32574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cloud-fan Could you review this PR, please. |
| } | ||
| } | ||
|
|
||
| test("SPARK-35427: datetime rebasing in the EXCEPTION mode") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to clean up the existing tests to remove code that are being tested here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me find out the places where we check the default mode (EXCEPTION).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can avoid checking the default EXCEPTION mode at least in the places:
Lines 142 to 146 in 0494dc9
// By default we should fail to write ancient datetime values. if (tsOutputType != "INT96") { val e = intercept[SparkException](df.write.parquet(path3_0)) assert(e.getCause.getCause.getCause.isInstanceOf[SparkUpgradeException]) } spark/external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
Lines 1835 to 1837 in 2bd3254
// By default we should fail to write ancient datetime values. val e = intercept[SparkException](df.write.format("avro").save(path3_0)) assert(e.getCause.getCause.getCause.isInstanceOf[SparkUpgradeException])
@cloud-fan Let me know if you think that there are other places.
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Test build #138638 has finished for PR 32574 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #138757 has finished for PR 32574 at commit
|
|
@cloud-fan Any objections to the changes? |
|
@gengliangwang @HyukjinKwon Could you take a look at the PR, please. |
|
thanks, merging to master! |
What changes were proposed in this pull request?
Add tests to check the
EXCEPTIONrebase mode explicitly in the datasources:DATEtype andTIMESTAMP:INT96,TIMESTAMP_MICROS,TIMESTAMP_MILLISDATEtype andTIMESTAMP:timestamp-millisandtimestamp-micros.Why are the changes needed?
EXCEPTIONrebase mode should be checked independently from the default settings.Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the affected test suites: