[SPARK-34981][SQL][FOLLOWUP] Use SpecificInternalRow in ApplyFunctionExpression #32647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @cloud-fan |
HyukjinKwon
approved these changes
May 24, 2021
maropu
approved these changes
May 24, 2021
|
Kubernetes integration test starting |
cloud-fan
approved these changes
May 24, 2021
|
Kubernetes integration test status success |
Member
|
Merged to master. |
|
Test build #138861 has finished for PR 32647 at commit
|
Member
|
+1, late LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use
SpecificInternalRowinstead ofGenericInternalRowto avoid boxing / unboxing cost.Why are the changes needed?
Since it doesn't know the input row schema,
GenericInternalRowpotentially need to apply boxing for input arguments. It's better to useSpecificInternalRowinstead since we know input data types.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.