-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-35497][PYTHON] Enable plotly tests in pandas-on-Spark #32649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/build_and_test.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dongjoon-hyun FYI. Would you mind installing plotly at Python 3.8 in the Docker image we use when you find some time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I missed this comment last week. I only added plotly to Python 3.9 for now. I will add it to Python 3.8 soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i should have clarified it.now python 3.9 has to have this since we don't run he pyspark tests with python 3.8 anymore in the master branch, and pandas on Spark is only in the master branch.
|
Test build #138864 has finished for PR 32649 at commit
|
|
Test build #138865 has finished for PR 32649 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Kubernetes integration test status success |
ueshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, pending tests.
|
Test build #138894 has finished for PR 32649 at commit
|
itholic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Merged to master. |
xinrong-meng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What changes were proposed in this pull request?
This PR enables plot tests with plotly
Before:
After:
Why are the changes needed?
For test coverage.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
By running the tests.