-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-35527][SQL][TESTS] Fix HiveExternalCatalogVersionsSuite to pass with Java 11 #32670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #138959 has finished for PR 32670 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM (Pending CIs). Thank you so much, @sarutak !
|
Kubernetes integration test starting |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #138960 has finished for PR 32670 at commit
|
|
Kubernetes integration test status success |
|
uhoh, seems test failure related 😢 |
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Merged to master. |
|
Test build #138969 has finished for PR 32670 at commit
|
|
Refer to this link for build results (access rights to CI server needed): |
What changes were proposed in this pull request?
This PR fixes
HiveExternalCatalogVersionsSuite.With this change, only . version is set to
spark.sql.hive.metastore.version.Why are the changes needed?
I'm personally checking whether all the tests pass with Java 11 for the current
masterand I foundHiveExternalCatalogVersionsSuitefails.The reason is that Spark 3.0.2 and 3.1.1 doesn't accept
2.3.8as a hive metastore version.HiveExternalCatalogVersionsSuitedownloads Spark releases from https://dist.apache.org/repos/dist/release/spark/ and run test for each release. The Spark releases are3.0.2and3.1.1for the currentmasterfor now.spark/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
Lines 239 to 259 in e47e615
With Java 11, the suite run with a hive metastore version which corresponds to the builtin Hive version and it's
2.3.8for the currentmaster.spark/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
Lines 62 to 66 in 20750a3
But
branch-3.0andbranch-3.1doesn't accept2.3.8, the suite with Java 11 fails.Another solution would be backporting SPARK-34271 (#31371) but after a discussion, we prefer to fix the test,
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests with CI.