Skip to content

[SPARK-35059][SQL] Group exception messages in hive/execution #32694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
beliefer wants to merge 2 commits into from
Closed

[SPARK-35059][SQL] Group exception messages in hive/execution #32694

beliefer wants to merge 2 commits into from

Conversation

@beliefer
Copy link
Contributor

@beliefer beliefer commented May 28, 2021

What changes were proposed in this pull request?

This PR group exception messages in sql/hive/src/main/scala/org/apache/spark/sql/hive/execution.

Why are the changes needed?

It will largely help with standardization of error messages and its maintenance.

Does this PR introduce any user-facing change?

No. Error messages remain unchanged.

How was this patch tested?

No new tests - pass all original tests to make sure it doesn't break any existing behavior.

@github-actions github-actions bot added the SQL label May 28, 2021
@SparkQA
Copy link

SparkQA commented May 28, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43578/

@SparkQA
Copy link

SparkQA commented May 28, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43578/

@SparkQA
Copy link

SparkQA commented May 28, 2021

Test build #139057 has finished for PR 32694 at commit d4b2da4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@beliefer
Copy link
Contributor Author

beliefer commented May 31, 2021

ping @allisonwang-db

allisonwang-db
allisonwang-db approved these changes Jun 1, 2021
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala Outdated
new UnsupportedOperationException("inferSchema is not supported for hive data source.")
}

def requestedPartitionsMisMatchTableError(
Copy link
Contributor

@allisonwang-db allisonwang-db Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requestedPartitionsMismatchTablePartitionsError

@SparkQA
Copy link

SparkQA commented Jun 2, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43726/

@SparkQA
Copy link

SparkQA commented Jun 2, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43726/

@SparkQA
Copy link

SparkQA commented Jun 2, 2021

Test build #139202 has finished for PR 32694 at commit e9f5c1f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@beliefer
Copy link
Contributor Author

beliefer commented Jun 2, 2021

ping @cloud-fan

@cloud-fan
Copy link
Contributor

cloud-fan commented Jun 2, 2021

thanks, merging to master!

@cloud-fan cloud-fan closed this in 9f7cdb8 Jun 2, 2021
@beliefer
Copy link
Contributor Author

beliefer commented Jun 2, 2021

@allisonwang-db Thank you for review. @cloud-fan Thanks too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloud-fan cloud-fan cloud-fan approved these changes

@allisonwang-db allisonwang-db allisonwang-db approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@beliefer @SparkQA @cloud-fan @allisonwang-db