[SPARK-35562][DOC] Fix docs about Kubernetes and Yarn #32701
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some places in cluster-overview and submitting-applications that are obsolete, e.g. not mentioning Kubernetes or not mentioning the feature in Kubernetes correctly.
yaooqinn
reviewed
May 29, 2021
This is because, in bash, '#' can't come after '\'.
Member
|
ok to test |
|
Test build #139094 has finished for PR 32701 at commit
|
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
huskysun
changed the title
dongjoon-hyun
approved these changes
May 31, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master for Apache Spark 3.2.0.
Thank you, @huskysun .
Member
|
late +1, thanks @huskysun and @dongjoon-hyun. |
Contributor
Author
|
Thank you! @dongjoon-hyun @yaooqinn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some places in cluster-overview that are obsolete (i.e. not mentioning Kubernetes), and also fixed the Yarn spark-submit sample command in submitting-applications.
What changes were proposed in this pull request?
This is to fix the docs in "Cluster Overview" and "Submitting Applications" for places where Kubernetes is missed (mostly due to obsolete docs that haven't got updated) and where Yarn sample spark-submit command is incorrectly written.
Why are the changes needed?
To help the Spark users who uses Kubernetes as cluster manager to have a correct idea when reading the "Cluster Overview" doc page. Also to make the sample spark-submit command for Yarn actually runnable in the "Submitting Applications" doc page, by removing the invalid comment after line continuation char
\.Does this PR introduce any user-facing change?
No
How was this patch tested?
No test, as this is doc fix.