Skip to content

[SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite#32732

Closed
gengliangwang wants to merge 2 commits intoapache:masterfrom
gengliangwang:setsuite
Closed

[SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite#32732
gengliangwang wants to merge 2 commits intoapache:masterfrom
gengliangwang:setsuite

Conversation

@gengliangwang
Copy link
Member

@gengliangwang gengliangwang commented Jun 1, 2021

What changes were proposed in this pull request?

Move Set command related test cases from SQLQuerySuite to a new test suite SetCommandSuite. There are 7 test cases in total.

Why are the changes needed?

Code refactoring. SQLQuerySuite is becoming big.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit tests

@gengliangwang gengliangwang requested a review from cloud-fan June 1, 2021 14:19
@github-actions github-actions bot added the SQL label Jun 1, 2021
@SparkQA
Copy link

SparkQA commented Jun 1, 2021

Test build #139166 has finished for PR 32732 at commit 3430609.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class SetSuite extends QueryTest with SharedSparkSession with ResetSystemProperties

@SparkQA
Copy link

SparkQA commented Jun 1, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43686/

@dongjoon-hyun dongjoon-hyun changed the title [Minor][TESTS] Move Set command related test cases to a single test suite [SPARK-35600][TESTS] Move Set command related test cases to a single test suite Jun 1, 2021
@dongjoon-hyun
Copy link
Member

Retest this please

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (one minor comment about the test suite naming)

@dongjoon-hyun
Copy link
Member

Thank you for update, @gengliangwang .

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-35600][TESTS] Move Set command related test cases to a single test suite [SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite Jun 1, 2021
@SparkQA
Copy link

SparkQA commented Jun 1, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43693/

@SparkQA
Copy link

SparkQA commented Jun 1, 2021

Test build #139174 has finished for PR 32732 at commit 97d8107.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class SetCommandSuite extends QueryTest with SharedSparkSession with ResetSystemProperties

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants