[SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite#32732
Closed
gengliangwang wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-35600][TESTS] Move Set command related test cases to SetCommandSuite#32732gengliangwang wants to merge 2 commits intoapache:masterfrom
gengliangwang wants to merge 2 commits intoapache:masterfrom
Conversation
cloud-fan
approved these changes
Jun 1, 2021
|
Test build #139166 has finished for PR 32732 at commit
|
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
Member
|
Retest this please |
dongjoon-hyun
approved these changes
Jun 1, 2021
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (one minor comment about the test suite naming)
Member
|
Thank you for update, @gengliangwang . |
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Test build #139174 has finished for PR 32732 at commit
|
HyukjinKwon
approved these changes
Jun 2, 2021
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move
Setcommand related test cases fromSQLQuerySuiteto a new test suiteSetCommandSuite. There are 7 test cases in total.Why are the changes needed?
Code refactoring.
SQLQuerySuiteis becoming big.Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests