[SPARK-35619][ML] Refactor LinearRegression - make huber support virtual centering #32759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Test build #139251 has finished for PR 32759 at commit
|
|
Kubernetes integration test status success |
Contributor
Author
|
friendly ping @srowen @WeichenXu123 |
srowen
reviewed
Jun 3, 2021
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Seems fine. Do you want to change more in one PR? separate ones are OK.
Contributor
Author
|
This should be the last PR related to virtual centering. I will refactor some common block in following PRs. |
Contributor
Author
|
Merged to master, thanks @srowen for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, for huber, make it support virtual centering
2, for
LeastSquares, it was impled in this way: optimize the linear part and then estimate the intercept. So just re-org the its agg and suite to keep in line with other aggs.Why are the changes needed?
for better convergence
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing and newly added testsuites