[SPARK-35665][SQL] Resolve UnresolvedAlias in CollectMetrics #32803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
LGTM. I just want to push this but you are so quickly .. |
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
HyukjinKwon
approved these changes
Jun 7, 2021
HyukjinKwon
pushed a commit
that referenced
this pull request
Jun 7, 2021
### What changes were proposed in this pull request? It's a long-standing bug that we forgot to resolve `UnresolvedAlias` in `CollectMetrics`. It's a bit hard to trigger this bug before 3.2 as most likely people won't create `UnresolvedAlias` when calling `Dataset.observe`. However things have been changed after #30974 This PR proposes to handle `CollectMetrics` in the rule `ResolveAliases`. ### Why are the changes needed? bug fix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? updated test Closes #32803 from cloud-fan/minor. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit a70e66e) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Member
|
Merged to master. |
|
Test build #139411 has finished for PR 32803 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It's a long-standing bug that we forgot to resolve
UnresolvedAliasinCollectMetrics. It's a bit hard to trigger this bug before 3.2 as most likely people won't createUnresolvedAliaswhen callingDataset.observe. However things have been changed after #30974This PR proposes to handle
CollectMetricsin the ruleResolveAliases.Why are the changes needed?
bug fix
Does this PR introduce any user-facing change?
no
How was this patch tested?
updated test