-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-35666][ML] gemv skip array shape checking #32805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Kubernetes integration test starting |
|
Test build #139420 has finished for PR 32805 at commit
|
|
Kubernetes integration test status success |
|
retest this please |
|
Kubernetes integration test starting |
|
Test build #139444 has finished for PR 32805 at commit
|
|
Kubernetes integration test status success |
8fedbd5 to
70b86fc
Compare
|
Kubernetes integration test starting |
|
Test build #139455 has finished for PR 32805 at commit
|
|
Kubernetes integration test status success |
|
friendly ping @srowen @WeichenXu123 |
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok pending tests
|
retest this please |
|
Test build #139631 has finished for PR 32805 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
@srowen I think this PR is ready. |
|
retest this please |
|
Test build #139824 has finished for PR 32805 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Merged to master, thanks @srowen for reviewing! |
What changes were proposed in this pull request?
In existing impls, it is common case that the vector/matrix need to be sliced/copied just due to shape match.
which makes the logic complex and introduce extra costing of slicing & copying.
Why are the changes needed?
1, avoid slicing and copying due to shape checking;
2, simpify the usages;
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing testsuites