-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-35754][CORE] Add config to put migrating blocks on disk only #32902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Ngone51 Please have a look. |
|
cc @holdenk |
|
ok to test |
|
Could you check the UT failure, @q2w ? If it passes in your environment, please re-trigger GitHub Action. |
…in number of arguments in replicateBlocks method in BlockManager
|
@q2w, can you rebase and create a new PR? Seems like GA in this PR is somehow messed up. |
|
Test build #140375 has finished for PR 32902 at commit
|
|
This would be inconsistent with the expectation of the storage level set on the RDD/DF. |
@mridulm That's correct. In the current flow of decommissioning,the blocks being offloaded can replace existing cached blocks on peer block manager if enough memory is not available. This way we are saving one cached block by loosing another. |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
What changes were proposed in this pull request?
This PR adds a config which makes block manager decommissioner to migrate block data on disk only.
Why are the changes needed?
While migrating block data, if enough memory is not available on peer block managers existing blocks are dropped. After this PR migrating blocks won't drop any existing blocks.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT in BlockManagerSuite