[SPARK-33603][SQL] Grouping exception messages in execution/command#32951
Closed
dgd-contributor wants to merge 20 commits intoapache:masterfrom
Closed
[SPARK-33603][SQL] Grouping exception messages in execution/command#32951dgd-contributor wants to merge 20 commits intoapache:masterfrom
dgd-contributor wants to merge 20 commits intoapache:masterfrom
Conversation
dgd-contributor
force-pushed
the
SPARK-33603_grouping_execution/command
branch
4 times, most recently
from
84a6b4b to
6e7a8c2
Compare
dgd-contributor
changed the title
dgd-contributor
force-pushed
the
SPARK-33603_grouping_execution/command
branch
from
6e7a8c2 to
3458d5c
Compare
dgd-contributor
force-pushed
the
SPARK-33603_grouping_execution/command
branch
from
3458d5c to
24e7f11
Compare
dgd-contributor
force-pushed
the
SPARK-33603_grouping_execution/command
branch
from
60a1c69 to
6595e64
Compare
Author
|
@beliefer can you review this if you got time? Thanks |
Author
|
cc @allisonwang-db Could you check whether the naming reasonable? |
beliefer
reviewed
Jul 1, 2021
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Jul 1, 2021
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Jul 1, 2021
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Jul 1, 2021
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Jul 1, 2021
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Outdated
Show resolved
Hide resolved
Author
|
@beliefer I've resolve the rest change requires, can you review them |
Contributor
|
cc @allisonwang-db Please check the naming reasonable. |
Author
Author
|
@beliefer maybe @allisonwang-db is a little bit busy, if there anyone else can review this? |
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Outdated
Show resolved
Hide resolved
Author
|
@allisonwang-db can you re-review, I've resolved all the naming change requests |
allisonwang-db
approved these changes
Jul 8, 2021
Contributor
allisonwang-db
left a comment
allisonwang-db
left a comment
There was a problem hiding this comment.
Thanks! Looks good.
Author
|
cc @cloud-fan |
Contributor
|
@cloud-fan LGTM. |
Member
|
Jenkins, retest this please |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #140901 has finished for PR 32951 at commit
|
gengliangwang
approved these changes
Jul 12, 2021
Member
gengliangwang
left a comment
gengliangwang
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
gengliangwang
changed the title
Member
|
Merging to master/3.2 |
gengliangwang
pushed a commit
that referenced
this pull request
Jul 12, 2021
### What changes were proposed in this pull request? This PR group exception messages in sql/core/src/main/scala/org/apache/spark/sql/execution/command ### Why are the changes needed? It will largely help with standardization of error messages and its maintenance. ### Does this PR introduce any user-facing change? No. Error messages remain unchanged. ### How was this patch tested? No new tests - pass all original tests to make sure it doesn't break any existing behavior. Closes #32951 from dgd-contributor/SPARK-33603_grouping_execution/command. Authored-by: dgd-contributor <dgd_contributor@viettel.com.vn> Signed-off-by: Gengliang Wang <gengliang@apache.org> (cherry picked from commit d03f716) Signed-off-by: Gengliang Wang <gengliang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR group exception messages in sql/core/src/main/scala/org/apache/spark/sql/execution/command
Why are the changes needed?
It will largely help with standardization of error messages and its maintenance.
Does this PR introduce any user-facing change?
No. Error messages remain unchanged.
How was this patch tested?
No new tests - pass all original tests to make sure it doesn't break any existing behavior.