Skip to content

[SPARK-35472][PYTHON] Fix disallow_untyped_defs mypy checks for pyspark.pandas.generic#32957

Closed
ueshin wants to merge 5 commits intoapache:masterfrom
ueshin:issues/SPARK-35472/disallow_untyped_defs
Closed

[SPARK-35472][PYTHON] Fix disallow_untyped_defs mypy checks for pyspark.pandas.generic#32957
ueshin wants to merge 5 commits intoapache:masterfrom
ueshin:issues/SPARK-35472/disallow_untyped_defs

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented Jun 18, 2021

What changes were proposed in this pull request?

Adds more type annotations in the file python/pyspark/pandas/generic.py and fixes the mypy check failures.

Why are the changes needed?

We should enable more disallow_untyped_defs mypy checks.

Does this PR introduce any user-facing change?

Yes.
This PR adds more type annotations in pandas APIs on Spark module, which can impact interaction with development tools for users.

How was this patch tested?

The mypy check with a new configuration and existing tests should pass.

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Test build #139955 has finished for PR 32957 at commit d4c3537.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44482/

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44482/

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Test build #139956 has finished for PR 32957 at commit 67703d9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44483/

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44483/

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Test build #140000 has finished for PR 32957 at commit 847df02.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44526/

@ueshin
Copy link
Member Author

ueshin commented Jun 18, 2021

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44526/

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Test build #140002 has finished for PR 32957 at commit 847df02.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ueshin ueshin marked this pull request as ready for review June 18, 2021 21:45
@ueshin
Copy link
Member Author

ueshin commented Jun 18, 2021

cc @HyukjinKwon @itholic @xinrong-databricks

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44528/

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44528/

@ueshin ueshin changed the title [SPARK-35472][PYTHON] Fix disallow_untyped_defs mypy checks. [SPARK-35472][PYTHON] Fix disallow_untyped_defs mypy checks for pyspark.pandas.generic Jun 19, 2021
@SparkQA
Copy link

SparkQA commented Jun 19, 2021

Test build #140008 has finished for PR 32957 at commit 4d8a751.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 19, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44534/

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants