Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jun 18, 2021

What changes were proposed in this pull request?

This PR aims to upgrade SBT to 1.5.4.

Why are the changes needed?

SBT 1.5.4 is released 5 days ago.

This will bring the latest bug fixes like the following.

  • Fixes BSP on ARM Macs by keeping JNI server socket to keep using JNI
  • Fixes compiler ClassLoader list to use compilerJars.toList (For Scala 3, this drops support for 3.0.0-M2)
  • Fixes undercompilation of package object causing "Symbol 'type X' is missing from the classpath"
  • Fixes overcompilation with scalac -release flag
  • Fixes build/exit notification not closing BSP channel
  • Fixes POM file's Maven repository ID character restriction to match that of Maven

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

@github-actions github-actions bot added the BUILD label Jun 18, 2021
@dongjoon-hyun dongjoon-hyun requested a review from sarutak June 18, 2021 21:39
@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44529/

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44529/

@SparkQA
Copy link

SparkQA commented Jun 18, 2021

Test build #140003 has finished for PR 32966 at commit 4ea7773.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems GA was passed.

@sarutak
Copy link
Member

sarutak commented Jun 19, 2021

retest this please.

@SparkQA
Copy link

SparkQA commented Jun 19, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44543/

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon , @viirya , @sarutak .
Merged to master for Apache Spark 3.2.0.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-35818 branch June 19, 2021 07:18
@SparkQA
Copy link

SparkQA commented Jun 19, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44543/

@SparkQA
Copy link

SparkQA commented Jun 19, 2021

Test build #140017 has finished for PR 32966 at commit 4ea7773.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants