[SPARK-35812][PYTHON] Throw ValueError if version and timestamp are used together in to_delta#33023
Closed
Yikun wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-35812][PYTHON] Throw ValueError if version and timestamp are used together in to_delta#33023Yikun wants to merge 2 commits intoapache:masterfrom
Yikun wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
Test build #140141 has finished for PR 33023 at commit
|
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
Member
|
cc @cloud-fan |
cloud-fan
reviewed
Jun 23, 2021
| 4 14 | ||
| """ | ||
| if version is not None and timestamp is not None: | ||
| raise ValueError("version and timestamp cannot be used together.") |
Member
Author
There was a problem hiding this comment.
added the doc for version and timestamp
cloud-fan
approved these changes
Jun 23, 2021
|
Kubernetes integration test starting |
|
Test build #140194 has finished for PR 33023 at commit
|
|
Kubernetes integration test status failure |
HyukjinKwon
approved these changes
Jun 23, 2021
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Throw ValueError if version and timestamp are used together in to_delta
Why are the changes needed?
read_delta has arguments named
versionandtimestamp, but they cannot be used together.We should raise the proper error message when they are used together.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT