Skip to content

[SPARK-33741][FOLLOW-UP][CORE] Rename the min threshold time speculation config#33037

Closed
Ngone51 wants to merge 1 commit intoapache:masterfrom
Ngone51:spark-33741-followup
Closed

[SPARK-33741][FOLLOW-UP][CORE] Rename the min threshold time speculation config#33037
Ngone51 wants to merge 1 commit intoapache:masterfrom
Ngone51:spark-33741-followup

Conversation

@Ngone51
Copy link
Member

@Ngone51 Ngone51 commented Jun 23, 2021

What changes were proposed in this pull request?

This's a follow-up of #30710.
Rename the conf from spark.speculation.min.threshold to spark.speculation.minTaskRuntime.

Why are the changes needed?

To follow the config naming policy.

Does this PR introduce any user-facing change?

No (since Spark 3.2 hasn't been released).

How was this patch tested?

Pass existing tests.

@Ngone51
Copy link
Member Author

Ngone51 commented Jun 23, 2021

cc @cloud-fan @tgravescs @redsanket

@SparkQA
Copy link

SparkQA commented Jun 23, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44715/

@SparkQA
Copy link

SparkQA commented Jun 23, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44715/

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@SparkQA
Copy link

SparkQA commented Jun 23, 2021

Test build #140188 has finished for PR 33037 at commit dd3a716.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 7f93773 Jun 23, 2021
@Ngone51
Copy link
Member Author

Ngone51 commented Jun 23, 2021

thanks all!!

@Ngone51 Ngone51 deleted the spark-33741-followup branch June 23, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants