[SPARK-35930][BUILD] Upgrade kinesis-client to 1.14.4#33133
[SPARK-35930][BUILD] Upgrade kinesis-client to 1.14.4#33133sarutak wants to merge 1 commit intoapache:masterfrom
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making a PR, @sarutak . BTW, is it tested manually because this is not covered by CIs?
|
@dongjoon-hyun Thank you, I forgot that kinesis tests don't run on CI. So, I tried with I also ran kinesis tests on the commit a9e8e05 which upgraded kinesis-client to |
|
Test build #140357 has finished for PR 33133 at commit
|
|
Since there are some previous works to address the Guava restriction, ping @viirya , @sunchao , @HyukjinKwon in order to get some advice. |
Yeah, a9e8e05 was not merged to |
|
Does it mean we'd need to upgrade Guava version in order for kinesis-client to work in Spark 3.2.0? |
|
FYI, I re-opened #29326 to try upgrading guava again. |
|
Shall we revert a9e8e05 first? |
…dk 1.11.844" ### What changes were proposed in this pull request? This PR reverts the change of SPARK-34549 ( #31658). ### Why are the changes needed? See #33133. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Closes #33145 from sarutak/revert-SPARK-34549. Authored-by: Kousuke Saruta <sarutak@oss.nttdata.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
|
Since SPARK-34549 is reverted, I'll close this PR, @sarutak . Thank you for checking. After Guava issue is resolved, feel free to reopen this. |
What changes were proposed in this pull request?
This PR upgrades kinesis-client from 1.14.0 to 1.14.4
Why are the changes needed?
Upgrading to 1.14.1 or newer is recommended by the community for users who use kinesis-client 1.14.0 due to a bug.
https://github.com/awslabs/amazon-kinesis-client/tree/master#recommended-upgrade-for-all-users-of-the-1x-amazon-kinesis-client
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran
*Kinesis*SuitewithENABLE_KINESIS_TESTS=1and they passed on an AWS environment