Revert "[SPARK-33995][SQL] Expose make_interval as a Scala function"#33143
Revert "[SPARK-33995][SQL] Expose make_interval as a Scala function"#33143MaxGekk wants to merge 1 commit intoapache:masterfrom
Conversation
This reverts commit e6753c9.
|
Kubernetes integration test starting |
|
cc @MrPowers and @cloud-fan |
|
Kubernetes integration test status success |
|
I think it's fine though since we didn't deprecate |
|
Test build #140402 has finished for PR 33143 at commit
|
|
Refer to this link for build results (access rights to CI server needed): |
|
👍 Thanks for creating something better @MaxGekk and thanks for the ping @dongjoon-hyun. |
| * @group datetime_funcs | ||
| * @since 3.2.0 | ||
| */ | ||
| def make_interval( |
There was a problem hiding this comment.
do we have make_ym_interval and make_dt_interval now?
There was a problem hiding this comment.
I wouldn't remove until we decide to deprecate CalendarIntervalType?
There was a problem hiding this comment.
Is it better to remove it before a release? @since 3.2.0
There was a problem hiding this comment.
Will we deprecate and remove CalendarIntervalType?
There was a problem hiding this comment.
do we have make_ym_interval and make_dt_interval now?
@cloud-fan As SQL functions, see #32645 and #32601 . The functions haven't been exposed to Scala/Python/R APIs yet.
Will we deprecate and remove CalendarIntervalType?
@HyukjinKwon Yes, we will I hope. The question is only when.
|
Thanks all for reviews. Merging to master. |
8 participants
What changes were proposed in this pull request?
This reverts commit e6753c9.
Why are the changes needed?
The
make_intervalfunction aims to construct values of the legacy interval typeCalendarIntervalTypewhich will be substituted by ANSI interval types (see SPARK-27790). Since the function has not been released yet, it would be better to don't expose it via public API at all.Does this PR introduce any user-facing change?
Should not since the
make_intervalfunction has not been released yet.How was this patch tested?
By existing test suites, and GA/jenkins builds.