[SPARK-35969][K8S] Make the pod prefix more readable and tallied with K8S DNS Label Names#33171
[SPARK-35969][K8S] Make the pod prefix more readable and tallied with K8S DNS Label Names#33171yaooqinn wants to merge 2 commits intoapache:masterfrom
Conversation
Make the pod prefix more readable and tallied with K8S DNS Label Names
|
Test build #140504 has finished for PR 33171 at commit
|
|
Test build #140509 has finished for PR 33171 at commit
|
|
Kubernetes integration test starting |
|
cc @dongjoon-hyun @holdenk thanks |
|
Kubernetes integration test status success |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @yaooqinn .
Merged to master for Apache Spark 3.2.0.
What changes were proposed in this pull request?
By default, the executor pod prefix is generated by the app name. It handles characters that match [^a-z0-9\\-] differently. The '.' and all whitespaces will be converted to '-', but other ones to empty string. Especially, characters like '_', '|' are commonly used as a word separator in many languages.
According to the K8S DNS Label Names, see https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names, we can convert all special characters to
-.For example,
Why are the changes needed?
For better UX
Does this PR introduce any user-facing change?
yes, the executor pod name might look better
How was this patch tested?
add new ones