Skip to content

[SPARK-33996][BUILD][FOLLOW-UP] Match SBT's plugin checkstyle version to Maven's#33207

Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon:SPARK-33996
Closed

[SPARK-33996][BUILD][FOLLOW-UP] Match SBT's plugin checkstyle version to Maven's#33207
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon:SPARK-33996

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a followup of #31019 that forgot to update SBT's to match.

Why are the changes needed?

To use the same version in both Maven and SBT.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI should test them.

@HyukjinKwon
Copy link
Member Author

cc @williamhyun can you review this please?

@github-actions github-actions bot added the BUILD label Jul 5, 2021
@SparkQA
Copy link

SparkQA commented Jul 5, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45142/

@SparkQA
Copy link

SparkQA commented Jul 5, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45142/

@HyukjinKwon HyukjinKwon changed the title [SPARK-33996][BUILD] Match SBT's plugin checkstyle version to Maven's [SPARK-33996][BUILD][FOLLOW-UP] Match SBT's plugin checkstyle version to Maven's Jul 5, 2021
@SparkQA
Copy link

SparkQA commented Jul 5, 2021

Test build #140629 has finished for PR 33207 at commit 055b472.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

cc @sarutak @srowen too can you take a quick look please?

@HyukjinKwon
Copy link
Member Author

this more specifically affects ./dev/sbt-checkstyle which I checked that it passes locally

@HyukjinKwon
Copy link
Member Author

Merged to master and branch-3.2.

Thanks @sarutak!

HyukjinKwon added a commit that referenced this pull request Jul 5, 2021
… to Maven's

### What changes were proposed in this pull request?

This PR is a followup of #31019 that forgot to update SBT's to match.

### Why are the changes needed?

To use the same version in both Maven and SBT.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI should test them.

Closes #33207 from HyukjinKwon/SPARK-33996.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 2fe6c94)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@sarutak
Copy link
Member

sarutak commented Jul 5, 2021

I also double-chedked on my laptop.

@HyukjinKwon HyukjinKwon deleted the SPARK-33996 branch January 4, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants