[SPARK-36037][TESTS][FOLLOWUP] Avoid wrong test results on daylight saving time#33354
Closed
gengliangwang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-36037][TESTS][FOLLOWUP] Avoid wrong test results on daylight saving time#33354gengliangwang wants to merge 1 commit intoapache:masterfrom
gengliangwang wants to merge 1 commit intoapache:masterfrom
Conversation
MaxGekk
approved these changes
Jul 15, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
beliefer
approved these changes
Jul 15, 2021
| test("datetime function localtimestamp") { | ||
| outstandingTimezonesIds.foreach { zid => | ||
| // Verify with multiple outstanding time zones which has no daylight saving time. | ||
| Seq("UTC", "Africa/Dakar", "Asia/Hong_Kong").foreach { zid => |
MaxGekk
approved these changes
Jul 15, 2021
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
+1, LGTM. Merging to master/3.2. GA passed.
Thank you, @gengliangwang and @beliefer for review.
MaxGekk
pushed a commit
that referenced
this pull request
Jul 15, 2021
…aving time ### What changes were proposed in this pull request? Only use the zone ids that has no daylight saving for testing `localtimestamp` ### Why are the changes needed? #33346 (comment) MaxGekk suggests that we should avoid wrong results if possible. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test Closes #33354 from gengliangwang/FIxDST. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit 564d3de) Signed-off-by: Max Gekk <max.gekk@gmail.com>
|
Test build #141054 has finished for PR 33354 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Only use the zone ids that has no daylight saving for testing
localtimestampWhy are the changes needed?
#33346 (comment) @MaxGekk suggests that we should avoid wrong results if possible.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test