[SPARK-36210][SQL] Preserve column insertion order in Dataset.withColumns #33423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #141265 has finished for PR 33423 at commit
|
Member
|
cc @viirya |
HyukjinKwon
reviewed
Jul 20, 2021
| } | ||
|
|
||
| test("SPARK-36210: withColumns preserve insertion ordering") { | ||
| val df = Seq(1, 2, 3).toDS() |
Member
There was a problem hiding this comment.
can we add a test with a duplicate column names?
Member
There was a problem hiding this comment.
I think withColumns doesn't allow duplicate column names.
Member
There was a problem hiding this comment.
There is one test in DataFrameSuite.
viirya
approved these changes
Jul 20, 2021
Member
|
@HyukjinKwon Any more comments? If no, I will merge this tomorrow. Thanks. |
Member
|
nope lgtm too! |
Member
|
Seems OK to me. I'm very slightly concerned about the behavior change - column order is different - but seems worth it as a 'fix'. |
Member
|
Thanks. Merging to master/3.2/3.1/3.0 |
viirya
pushed a commit
that referenced
this pull request
Jul 20, 2021
…umns ### What changes were proposed in this pull request? Preserve the insertion order of columns in Dataset.withColumns ### Why are the changes needed? It is the expected behavior. We preserve insertion order in all other places. ### Does this PR introduce _any_ user-facing change? No. Currently Dataset.withColumns is not actually used anywhere to insert more than one column. This change is to make sure it behaves as expected when it is used for that purpose in future. ### How was this patch tested? Added test in DatasetSuite Closes #33423 from koertkuipers/feat-withcolumns-preserve-order. Authored-by: Koert Kuipers <koert@tresata.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com> (cherry picked from commit bf680bf) Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
viirya
pushed a commit
that referenced
this pull request
Jul 20, 2021
…umns ### What changes were proposed in this pull request? Preserve the insertion order of columns in Dataset.withColumns ### Why are the changes needed? It is the expected behavior. We preserve insertion order in all other places. ### Does this PR introduce _any_ user-facing change? No. Currently Dataset.withColumns is not actually used anywhere to insert more than one column. This change is to make sure it behaves as expected when it is used for that purpose in future. ### How was this patch tested? Added test in DatasetSuite Closes #33423 from koertkuipers/feat-withcolumns-preserve-order. Authored-by: Koert Kuipers <koert@tresata.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com> (cherry picked from commit bf680bf) Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
viirya
pushed a commit
that referenced
this pull request
Jul 20, 2021
…umns ### What changes were proposed in this pull request? Preserve the insertion order of columns in Dataset.withColumns ### Why are the changes needed? It is the expected behavior. We preserve insertion order in all other places. ### Does this PR introduce _any_ user-facing change? No. Currently Dataset.withColumns is not actually used anywhere to insert more than one column. This change is to make sure it behaves as expected when it is used for that purpose in future. ### How was this patch tested? Added test in DatasetSuite Closes #33423 from koertkuipers/feat-withcolumns-preserve-order. Authored-by: Koert Kuipers <koert@tresata.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com> (cherry picked from commit bf680bf) Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
Member
|
I'm not super against back-porting, but is more questionable given the behavior change |
Member
|
Hmm, |
Member
|
Oh I see, OK |
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…umns ### What changes were proposed in this pull request? Preserve the insertion order of columns in Dataset.withColumns ### Why are the changes needed? It is the expected behavior. We preserve insertion order in all other places. ### Does this PR introduce _any_ user-facing change? No. Currently Dataset.withColumns is not actually used anywhere to insert more than one column. This change is to make sure it behaves as expected when it is used for that purpose in future. ### How was this patch tested? Added test in DatasetSuite Closes apache#33423 from koertkuipers/feat-withcolumns-preserve-order. Authored-by: Koert Kuipers <koert@tresata.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com> (cherry picked from commit bf680bf) Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
fishcus
pushed a commit
to fishcus/spark
that referenced
this pull request
Jan 12, 2022
…umns ### What changes were proposed in this pull request? Preserve the insertion order of columns in Dataset.withColumns ### Why are the changes needed? It is the expected behavior. We preserve insertion order in all other places. ### Does this PR introduce _any_ user-facing change? No. Currently Dataset.withColumns is not actually used anywhere to insert more than one column. This change is to make sure it behaves as expected when it is used for that purpose in future. ### How was this patch tested? Added test in DatasetSuite Closes apache#33423 from koertkuipers/feat-withcolumns-preserve-order. Authored-by: Koert Kuipers <koert@tresata.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com> (cherry picked from commit bf680bf) Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Preserve the insertion order of columns in Dataset.withColumns
Why are the changes needed?
It is the expected behavior. We preserve insertion order in all other places.
Does this PR introduce any user-facing change?
No. Currently Dataset.withColumns is not actually used anywhere to insert more than one column. This change is to make sure it behaves as expected when it is used for that purpose in future.
How was this patch tested?
Added test in DatasetSuite