Skip to content

[SPARK-36225][PYTHON][DOCS] Use DataFrame in python docstrings #33438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dominikgehl wants to merge 4 commits into from
Closed

[SPARK-36225][PYTHON][DOCS] Use DataFrame in python docstrings #33438

dominikgehl wants to merge 4 commits into from

Conversation

@dominikgehl
Copy link
Contributor

@dominikgehl dominikgehl commented Jul 20, 2021

What changes were proposed in this pull request?

Changing references to Dataset in python docstrings to DataFrame

Why are the changes needed?

no Dataset class in pyspark

Does this PR introduce any user-facing change?

No

How was this patch tested?

Doc change only

HyukjinKwon
HyukjinKwon reviewed Jul 20, 2021
View reviewed changes
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jul 20, 2021

Nice, thanks for your contributions!

@HyukjinKwon HyukjinKwon changed the title [SPARK-36225] Use DataFrame in python docstrings [SPARK-36225][PYTHON][DOCS] Use DataFrame in python docstrings Jul 20, 2021
HyukjinKwon
HyukjinKwon approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

HyukjinKwon
HyukjinKwon reviewed Jul 20, 2021
View reviewed changes
HyukjinKwon
HyukjinKwon reviewed Jul 20, 2021
View reviewed changes
@SparkQA
Copy link

SparkQA commented Jul 20, 2021

Test build #141325 has finished for PR 33438 at commit eb61e57.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 20, 2021

Test build #141329 has finished for PR 33438 at commit 7e98751.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 20, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45840/

@SparkQA
Copy link

SparkQA commented Jul 20, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45840/

@SparkQA
Copy link

SparkQA commented Jul 20, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45844/

@SparkQA
Copy link

SparkQA commented Jul 20, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45844/

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jul 23, 2021

@dominikgehl can you check the build status? linter failed

dominikgehl and others added 3 commits July 23, 2021 12:44
@dominikgehl
python docstrings should refer to DataFrame not Dataset
6aa2488
@dominikgehl @HyukjinKwon
doc wording
fe068b6 
Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
@dominikgehl @HyukjinKwon
doc wording
1b181d8 
Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
@dominikgehl dominikgehl force-pushed the feature/SPARK-36225 branch from 7e98751 to 1b181d8 Compare July 23, 2021 10:45
@SparkQA
Copy link

SparkQA commented Jul 23, 2021

Test build #141554 has finished for PR 33438 at commit 1b181d8.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jul 23, 2021

@dominikgehl mind taking a look for the linter failure?

@SparkQA
Copy link

SparkQA commented Jul 23, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46072/

@SparkQA
Copy link

SparkQA commented Jul 23, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46072/

@dominikgehl
Copy link
Contributor Author

dominikgehl commented Jul 23, 2021

@dominikgehl mind taking a look for the linter failure?

Done

@SparkQA
Copy link

SparkQA commented Jul 23, 2021

Test build #141561 has finished for PR 33438 at commit 9c79b34.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 23, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46079/

@SparkQA
Copy link

SparkQA commented Jul 23, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46079/

HyukjinKwon pushed a commit that referenced this pull request Jul 24, 2021
@dominikgehl @HyukjinKwon
[SPARK-36225][PYTHON][DOCS] Use DataFrame in python docstrings
29c0b1e 
### What changes were proposed in this pull request?
Changing references to Dataset in python docstrings to DataFrame

### Why are the changes needed?
no Dataset class in pyspark

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Doc change only

Closes #33438 from dominikgehl/feature/SPARK-36225.

Lead-authored-by: Dominik Gehl <dog@open.ch>
Co-authored-by: Dominik Gehl <gehl@fastmail.fm>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit ae1c20e)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jul 24, 2021

Merged to master, branch-3.2 and branch-3.1.

HyukjinKwon pushed a commit that referenced this pull request Jul 24, 2021
@dominikgehl @HyukjinKwon
[SPARK-36225][PYTHON][DOCS] Use DataFrame in python docstrings
824426e 
### What changes were proposed in this pull request?
Changing references to Dataset in python docstrings to DataFrame

### Why are the changes needed?
no Dataset class in pyspark

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Doc change only

Closes #33438 from dominikgehl/feature/SPARK-36225.

Lead-authored-by: Dominik Gehl <dog@open.ch>
Co-authored-by: Dominik Gehl <gehl@fastmail.fm>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit ae1c20e)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@dominikgehl dominikgehl deleted the feature/SPARK-36225 branch July 26, 2021 06:05
flyrain pushed a commit to flyrain/spark that referenced this pull request Sep 21, 2021
@dominikgehl @viirya
[SPARK-36225][PYTHON][DOCS] Use DataFrame in python docstrings
e142f5d 
### What changes were proposed in this pull request?
Changing references to Dataset in python docstrings to DataFrame

### Why are the changes needed?
no Dataset class in pyspark

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Doc change only

Closes apache#33438 from dominikgehl/feature/SPARK-36225.

Lead-authored-by: Dominik Gehl <dog@open.ch>
Co-authored-by: Dominik Gehl <gehl@fastmail.fm>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit ae1c20e)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

CORE ML PYTHON SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dominikgehl @HyukjinKwon @SparkQA