-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-3060] spark-shell.cmd doesn't accept application options in Windows OS #3350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ndows OS Added equivalent module as utils.sh and modified spark-shell2.cmd to use it to parse options.
|
Can one of the admins verify this patch? |
|
add to whitelist |
|
Thanks @tsudukim! Great to see this being fixed. The 1.2 deadline is a little close at this point so I'm not sure if we can pull in the changes here because windows batch is so complicated. I'll look at this after the release. |
|
Test build #23582 has started for PR 3350 at commit
|
|
Test build #23585 has started for PR 3350 at commit
|
|
Test build #23582 has finished for PR 3350 at commit
|
|
Test PASSed. |
|
Test build #23585 has finished for PR 3350 at commit
|
|
Test PASSed. |
|
Hey @tsudukim what is the status on this PR, are the changes ready from your side? Have you tested this on a Windows environment? |
|
Hi @andrewor14 yes I've tested on my environment. Would you check it? |
|
Alright, LGTM I'm merging this into master thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed this file to windows-utils.cmd to be more consistent
Added equivalent module as utils.sh and modified spark-shell2.cmd to use it to parse options.
Now we can use application options.
ex)
bin\spark-shell.cmd --master spark://master:7077 -i path\to\script.txt