Skip to content

Conversation

@tsudukim
Copy link
Contributor

Added equivalent module as utils.sh and modified spark-shell2.cmd to use it to parse options.

Now we can use application options.
ex) bin\spark-shell.cmd --master spark://master:7077 -i path\to\script.txt

…ndows OS

Added equivalent module as utils.sh and modified spark-shell2.cmd to use it to parse options.
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@andrewor14
Copy link
Contributor

add to whitelist

@andrewor14
Copy link
Contributor

Thanks @tsudukim! Great to see this being fixed. The 1.2 deadline is a little close at this point so I'm not sure if we can pull in the changes here because windows batch is so complicated. I'll look at this after the release.

@SparkQA
Copy link

SparkQA commented Nov 19, 2014

Test build #23582 has started for PR 3350 at commit 3a11361.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 19, 2014

Test build #23585 has started for PR 3350 at commit 4551e56.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 19, 2014

Test build #23582 has finished for PR 3350 at commit 3a11361.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23582/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Nov 19, 2014

Test build #23585 has finished for PR 3350 at commit 4551e56.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23585/
Test PASSed.

@andrewor14
Copy link
Contributor

Hey @tsudukim what is the status on this PR, are the changes ready from your side? Have you tested this on a Windows environment?

@tsudukim
Copy link
Contributor Author

Hi @andrewor14 yes I've tested on my environment. Would you check it?

@andrewor14
Copy link
Contributor

Alright, LGTM I'm merging this into master thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed this file to windows-utils.cmd to be more consistent

@asfgit asfgit closed this in 8d93247 Dec 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants