Skip to content

[SPARK-36254][PYTHON][FOLLOW-UP] Skip mlflow related tests in pandas on Spark#33589

Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon:SPARK-36254
Closed

[SPARK-36254][PYTHON][FOLLOW-UP] Skip mlflow related tests in pandas on Spark#33589
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon:SPARK-36254

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jul 30, 2021

What changes were proposed in this pull request?

This PR is a partial revert of #33567 that keeps the logic to skip mlflow related tests if that's not installed.

Why are the changes needed?

It's consistent with other libraries, e.g) PyArrow.
It also fixes up the potential dev breakage (see also #33567 (comment))

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

This is a partial revert. CI should test it out too.

@SparkQA
Copy link

SparkQA commented Jul 30, 2021

Test build #141900 has finished for PR 33589 at commit 1f74758.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@Yikun Yikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SparkQA
Copy link

SparkQA commented Jul 30, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46409/

@HyukjinKwon
Copy link
Member Author

Thanks, all tests passed. Merged to master and branch-3.2.

HyukjinKwon added a commit that referenced this pull request Jul 30, 2021
…on Spark

### What changes were proposed in this pull request?

This PR is a partial revert of #33567 that keeps the logic to skip mlflow related tests if that's not installed.

### Why are the changes needed?

It's consistent with other libraries, e.g) PyArrow.
It also fixes up the potential dev breakage (see also #33567 (comment))

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

This is a partial revert. CI should test it out too.

Closes #33589 from HyukjinKwon/SPARK-36254.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit dd2ca0a)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@SparkQA
Copy link

SparkQA commented Jul 30, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46409/

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. +1, LGTM.

@HyukjinKwon HyukjinKwon deleted the SPARK-36254 branch January 4, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants