[SPARK-36451][BUILD] Ivy skips looking for source and doc pom#33678
[SPARK-36451][BUILD] Ivy skips looking for source and doc pom#33678cxzl25 wants to merge 2 commits intoapache:masterfrom
Conversation
|
Are there any other implications to not looking for source or doc POMs? I can't quite think of them, just checking if there are any possible breakages. |
|
We can improve the execution speed of UT, because ivy will now connect to the remote repo, analyze three pom, source, doc pom, and only download the binary jar. |
|
I get that; that wasn't the question though. Are there any other implications of not downloading these, that are bad? |
|
AFAIK, there is no bad effect. Maybe you can trigger a test to verify, especially the UT execution speed of multiple versions of hive client. |
|
Jenkins test this please |
|
org.apache.ivy.plugins.parser.m2.PomModuleDescriptorParser # addSourcesAndJavadocArtifactsIfPresent |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #142563 has finished for PR 33678 at commit
|
|
Test build #142562 has finished for PR 33678 at commit
|
|
Merged to master |
What changes were proposed in this pull request?
Because SPARK-35863 Upgrade Ivy to 2.5.0, it supports skip searching the source and doc pom, but the remote repo will still be queried at present.
Why are the changes needed?
Can improve the speed of some UT, such as
IsolatedClientLoader#downloadVersion, no need to find source and doc pomDoes this PR introduce any user-facing change?
No
How was this patch tested?
manual UT